I have a 31" waist. Ordered the Medium. The waste band was ok sizing, maybe a bit too small compared wo what I'm used to. The fit otherwise is pretty loose. Even the inner lining is pretty loose. If you like loose fitting shorts, this would be great. If you are expecting a more "athletic" fit, I'd find something else.Otherwise, seems constructed well. Good pockets, nice materials.