Double check and definitely bleeding on the bench.
The master cylinder itself was great and worked great but one of the cup seals had no hole and the fluid couldn't move making bleeding impossible. Disassembled and a hole cut in the gasket. After that it worked great.